Skip to content

chore: enforce missing RuboCop enable directives - #368

Open
jbeckwith-oai wants to merge 1 commit into
mainfrom
codex/enforce-missing-cop-enable
Open

chore: enforce missing RuboCop enable directives#368
jbeckwith-oai wants to merge 1 commit into
mainfrom
codex/enforce-missing-cop-enable

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

Remove the examples/**/*.rb exclusion for Lint/MissingCopEnableDirective, making the cop part of the required lint policy across examples.

The audit found zero existing offenses, so this expands enforcement without source changes or new suppressions. Baseline: 0 offenses. Final: 0 offenses.

Castiron impact: none. Both .rubocop.yml and examples/ are excluded from Castiron generation, so regeneration cannot recreate or overwrite this change and no companion generator PR is needed.

Test Plan

  • Command: bundle exec rake lint with Ruby 4.0.6 and the repository bundle path.
  • Result: RuboCop inspected 2,611 files with no offenses; Sorbet reported no errors; 1,212 RBS files validated.

@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner August 11, 2026 23:26
@openai-sdks

openai-sdks Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

237/237 SDK tests passed in 8.704s for Ruby SDK PR #368.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 205ms
tests/chat-completions-create.test.ts ✅ Passed 266ms
tests/chat-completions-stream.test.ts ✅ Passed 133ms
tests/files-content-binary.test.ts ✅ Passed 197ms
tests/files-create-multipart.test.ts ✅ Passed 277ms
tests/files-list-pagination.test.ts ✅ Passed 206ms
tests/initialize-config.test.ts ✅ Passed 175ms
tests/instance-isolation.test.ts ✅ Passed 204ms
tests/models-list.test.ts ✅ Passed 274ms
tests/responses-background-lifecycle.test.ts ✅ Passed 234ms
tests/responses-body-method-errors.test.ts ✅ Passed 491ms
tests/responses-cancel-timeout.test.ts ✅ Passed 251ms
tests/responses-cancel.test.ts ✅ Passed 233ms
tests/responses-compact-retries.test.ts ✅ Passed 259ms
tests/responses-compact.test.ts ✅ Passed 234ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 138ms
tests/responses-create-advanced.test.ts ✅ Passed 165ms
tests/responses-create-disconnect.test.ts ✅ Passed 169ms
tests/responses-create-errors.test.ts ✅ Passed 278ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 141ms
tests/responses-create-retries.test.ts ✅ Passed 262ms
tests/responses-create-stream-failures.test.ts ✅ Passed 146ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 220ms
tests/responses-create-stream-wire.test.ts ✅ Passed 1.876s
tests/responses-create-stream.test.ts ✅ Passed 86ms
tests/responses-create-terminal-states.test.ts ✅ Passed 259ms
tests/responses-create-timeout.test.ts ✅ Passed 214ms
tests/responses-create.test.ts ✅ Passed 325ms
tests/responses-delete.test.ts ✅ Passed 345ms
tests/responses-input-items-errors.test.ts ✅ Passed 169ms
tests/responses-input-items-list.test.ts ✅ Passed 179ms
tests/responses-input-items-options.test.ts ✅ Passed 197ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 272ms
tests/responses-input-tokens-count.test.ts ✅ Passed 249ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.1s
tests/responses-not-found-errors.test.ts ✅ Passed 322ms
tests/responses-parse.test.ts ✅ Passed 202ms
tests/responses-retrieve-retries.test.ts ✅ Passed 349ms
tests/responses-retrieve.test.ts ✅ Passed 273ms
tests/responses-stored-method-errors.test.ts ✅ Passed 665ms
tests/retry-behavior.test.ts ✅ Passed 1.937s
tests/sdk-error-shape.test.ts ✅ Passed 375ms

View OkTest run #31546463400

SDK merge (7ac16d51365d) · head (5183ec1804ec) · base (8448a4cb1551) · OkTest (91635c6a2723)

@jbeckwith-oai jbeckwith-oai added the generator Touches generated SDK files label Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

generator Touches generated SDK files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant